TheThingsIndustries / generic-node-se

Generic Node Sensor Edition
https://www.genericnode.com
Other
109 stars 31 forks source link

Set default toolchain parameters #115

Closed franck-exceenis closed 3 years ago

franck-exceenis commented 3 years ago

Summary:

Set default toolchain parameters and allow to pass TOOLCHAIN_PREFIX in command line.

Changes:

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

elsalahy commented 3 years ago

@franck-exceenis Thanks for the pull request. I have a couple of concerns with the PR:

Please let me know what you think of these points.

elsalahy commented 3 years ago

Closed due to inactivity.