Feature/stm32 wl 1.0 - Githubissues

TheThingsIndustries / generic-node-se

Generic Node Sensor Edition

https://www.genericnode.com

Other

109 stars 31 forks source link

Feature/stm32 wl 1.0 #117

Closed elsalahy closed 3 years ago

elsalahy commented 3 years ago

Summary:

Adds the official ST STM32WL remote HAL subtree V1.0.0 instead of the personal 0.7 beta version.

This is part of #88

Changes:

Utilize STM32WL V1.0
Update structure and remote to accommodate the change
Update description and docs to reflect the change

Notes for Reviewers:

Tested all apps and they seem functional with no issues. This is only half of V1.0 integration.

Release Notes: (optional)

Will take a beta release before merging this PR.

CLAassistant commented 3 years ago

All committers have signed the CLA.

elsalahy commented 3 years ago

@johanstokking this looks like a major change because I had to change the subtree remote to the the new ST official remote, and effectively had to remove the older remote and rename it.

I considered a submodule approach, but we agreed #24 that this is the better approach, but please let me know if you have a different approach in mind?

P.S. Future changes will be more manageable, so I prefer the subtree approach as well

johanstokking commented 3 years ago

OK I see, indeed in some cases this is inevitable.

elsalahy commented 3 years ago

@azerimaker and @marnixcrouzen did you test the changes, any comments?