TheThingsIndustries / generic-node-se

Generic Node Sensor Edition
https://www.genericnode.com
Other
109 stars 31 forks source link

Feature/radio stack v1.0 #124

Closed elsalahy closed 3 years ago

elsalahy commented 3 years ago

Summary:

This PR updates the LoRaWAN stack and the Radio drivers from ST v0.7 (beta package) to ST v1.0 The LoRaWAN stack is based of LMN 4.4.4

Closes #88

Changes:

Notes for Reviewers:

Will open an issue later if the investigation requires it's own issue. In the meantime, please review and test all apps.

Release Notes: (optional)

...

elsalahy commented 3 years ago

This PR updates the stack to ST official v1.0 release of STM32Cube WL, and the LoRaWAN stack is based of LMN 4.4.4 It mainly affects the structure of any application that depends on the stack or the radio drivers. For example, now, you need to setup the keys in se-identity.h instead to commissioning.h

elsalahy commented 3 years ago

@johanstokking, I have enough reviewers for this PR, so no need to fo through the trouble of reviewing it, but it's good to be aware of this update and the changes that are needed to jump from v0.7 to v1.0

elsalahy commented 3 years ago

@azerimaker Can you please focus on reviewing the following:

  1. basic_lorawan functionality (focus on RSSI).
  2. basic_lorawan power consumption (focus on sleep current).

@marnixcrouzen Can you please only review:

  1. Compilation of all apps (CMAKE and STM32CUBE IDE)
  2. basic_lorawan app functionality
  3. Code changes
elsalahy commented 3 years ago

Fixed freertos_lorawan 🎉 as well, so please include this in you functional testing.

johanstokking commented 3 years ago

@johanstokking, I have enough reviewers for this PR, so no need to fo through the trouble of reviewing it, but it's good to be aware of this update and the changes that are needed to jump from v0.7 to v1.0

Cool, thanks, scanned through it. Good that you keep these large dependency updates and required project changes separate from functional stuff that we add.

elsalahy commented 3 years ago

Thanks @marnixcrouzen, were you able to test the applications functionality, mainly basic_lorawan and freertos_lorawan ?

mcserved commented 3 years ago

Thanks @marnixcrouzen, were you able to test the applications functionality, mainly basic_lorawan and freertos_lorawan ?

@elsalahy Yes, I was able to send data with OTAA with basic_lorawan, freertos seems to work (blue led blinks on interval) and basic app worked. Just in case, I tested again just now and everything still seemed to work.

elsalahy commented 3 years ago

The node average sleep current using the basic_lorawan app is very good. In the range of 1-2 uA (nA level) basic_lorawan app current measurements conditions:

image

azerimaker commented 3 years ago

@azerimaker Can you please focus on reviewing the following:

  1. basic_lorawan functionality (focus on RSSI).
  2. basic_lorawan power consumption (focus on sleep current).

Will do that. Otii readings are really promising, will verify it with the Joulescope.