TheThingsIndustries / generic-node-se

Generic Node Sensor Edition
https://www.genericnode.com
Other
108 stars 31 forks source link

Button not working in basic_lorawan #168

Closed mcserved closed 3 years ago

mcserved commented 3 years ago

Summary:

The TX_ON_EVENT options does not work in basic_lorawan, button presses do nothing.

Steps to Reproduce:

  1. Change EventType in lora_app.c to TX_ON_EVENT
  2. See if LoRa messages are transmitted on each button press.

What do you see now?

No button interaction.

What do you want to see instead?

Button presses handled properly in basic_lorawan.

How do you propose to implement this?

Change BUTTON_SW1 to BUTTON_SW1_PIN here: https://github.com/TheThingsIndustries/generic-node-se/blob/64d5f1dde90e6234c5c346f538453cfb24fce062/Software/app/basic_lorawan/lora_app.c#L177

And add a handler for EXTI3_IRQHandler in stm32wlxx_it.c (see EXTI1_IRQHandler for proper implementation).

Environment:

Bare metal

What can you do yourself and what do you need help with?

All