Feature/basic fuota - Githubissues

TheThingsIndustries / generic-node-se

Generic Node Sensor Edition

https://www.genericnode.com

Other

108 stars 31 forks source link

Feature/basic fuota #197

Closed elsalahy closed 3 years ago

elsalahy commented 3 years ago

Summary:

Adds basic fuota app and server The application attempts to handle an interoperability fuota test. closes #69 closes #82 closes #196

Changes:

A number of changes to the stack and the LmHandler
Adds a basic_fuota app

Notes for Reviewers:

Please observe the video I shared on slack. @johanstokking do you think I should add the JS test server within this application, or just point to this repo in the documentation.

Release Notes: (optional)

...

johanstokking commented 3 years ago

@johanstokking do you think I should add the JS test server within this application, or just point to this repo in the documentation.

Pointing to the repo is fine with me, thanks.

Anything specific I should look at here?

elsalahy commented 3 years ago

@johanstokking

Pointing to the repo is fine with me, thanks.

Good input, will update the documentation accordingly after your review.

Anything specific I should look at here?

Yes, only two things:

A Quick look at the stack changes/patches done, with commits that have lib prefix in them
Check overall application flow (using video in slack HW channel) and functionality in this lora_app.c

and that is it from your side, the rest is typical stuff.

elsalahy commented 3 years ago

This pull request closes #196 as well