TheThingsIndustries / generic-node-se

Generic Node Sensor Edition
https://www.genericnode.com
Other
110 stars 31 forks source link

SetorErase is missing #209

Open goran-mahovlic opened 3 years ago

goran-mahovlic commented 3 years ago

Summary:

Storing the configuration in flash, as far as we have seen Erase sector is not implemented ...

Why do we need this?

GNSE_Flash_BlockErase and GNSE_Flash_ChipErase. For our particular implementation we found that uses too much power as it needs a lot of time for erasing. ...

What is already there? What do you see now?

https://github.com/TheThingsIndustries/generic-node-se/blob/80b9796253f6563bcabe5c59ef3e65d8e35fc403/Software/lib/MX25R1635/nor_cmd.c#L1384 https://github.com/TheThingsIndustries/generic-node-se/blob/faf3bed4d041eaba85aed579ede85dedcb170c30/Software/lib/GNSE_HAL/GNSE_flash.c#L136 ...

What is missing? What do you want to see?

...

How do you propose to implement this?

...

Environment:

...

Acceptance Criteria:

...

What can you do yourself and what do you need help with?

...

elsalahy commented 3 years ago

Thanks for opening the issue.

Yes we can add sector erase to the abstraction layer, and developers can also use MxSE directly.