TheThingsIndustries / generic-node-se

Generic Node Sensor Edition
https://www.genericnode.com
Other
110 stars 31 forks source link

Feature/basic-lorawan #54

Closed elsalahy closed 4 years ago

elsalahy commented 4 years ago

Summary:

This PR Adds a simple basic LoRaWAN app that allows anyone to use the node as a modem. The applicaiton only activates needed pherephirals like RTC, USART, LPM and the SubGHz tranciever to ensure the lowest possible power consumbtion.

This app can be user as a power consumption reference when we activate other pherephirals and sensors.

Related to #37 Related to #30

Closes #53 Closes #52

Changes:

Notes for Reviewers:

This PR can be considere big, but I couldn't avoid it. Please review on per commit basis to make it easier as each commit is designed to be viewed and reviewed on it's own. You can think of it as 10 PRs 😄

Release Notes: (optional)

...

elsalahy commented 4 years ago

@azerimaker thanks for the quick review and the good feedback. Please take a look at my answers to your comments and let me know what do you think.

@johanstokking would love to get your review and detailed feedback on this PR.

elsalahy commented 4 years ago

This app is created as a reference for power consumption: Here are some snapshots of the current reference on Node #4

1- OTAA 14 dBm EU config image

2- Uplink every 10 seconds image

3- Uplink current: ~ 90 mA image

4- Sleep current: ~70 uA (We observed better on Node 1 in the range of nA) image

elsalahy commented 4 years ago

@johanstokking I have done the changes as per our discussion and added future improvement TODOs. Please take another look and let me know what you think