Closed azerimaker closed 3 years ago
Can you also fix any file that uses this absolute path C:/Users/Admin/OneDrive/TTI_Files/ST_Node/
@azerimaker There is still a number of issues
- The use of absolute paths in a number of files see:
- The use of
_
in folder/file naming instead of-
, we should have some coherency and stick with-
, seesch
andfab
Other issues:
- I don't think we should maintain
step
files in this way, Adding 100,000+ auto generated changes to one file and maintaining it is really not idealSo if you really want to maintain it, you could add these files in compressed format (Zip or RAR).
- End of files should have an extra empty line
- I see you added
LICENSES
and added one todo line, please remove the file and it is typically calledLICENSE
as we can add it later when we have some content- Typically images are used in the repo, but there is one that is not used, is this international (referring to
generic_node_batteryHolder.png
)?
I did some of those changes, but changing abs path to relative in all those 45 footprint files require manually changing each one of them one-by-one, and THB right now I have more important things to do.
Summary:
Adding latest design, production files and some renders of the Generic Node Sensor Edition.
Closes #1 Closes #5 Closes #6 Closes #58
Changes:
Additions:
Improvements:
Notes for Reviewers:
We need to improve docs and add a clear getting started guide.