search

TheThingsIndustries / lorawan-stack-docs

Documentation for The Things Stack
Apache License 2.0
32 stars 65 forks source link

Mark fields which are only returned by field mask in API #443

Open benolayinka opened 3 years ago

benolayinka commented 3 years ago

Summary

The ids , created_at, updated_at and deleted_at are always returned by the IS. Everything else needs to be selected.

Why do we need this ?

So people aren't confused when fields aren't returned by API

Can you do this yourself and submit a Pull Request?

Yes

NicolasMrad commented 2 years ago

Is this still relevant or to be done soon since it has been moved for 3 quarters so far

benolayinka commented 2 years ago

This is partially addressed by https://github.com/TheThingsIndustries/lorawan-stack-docs/pull/475

Actually adding a field mask indicator will require manually updating request metadata which we aren't gonna do right now. Will mark gold plating and remove milestone

https://github.com/TheThingsIndustries/lorawan-stack-docs/pull/475#issuecomment-884096007