TheThingsIndustries / protoc-gen-fieldmask

Generate field mask utilities from proto files
Apache License 2.0
10 stars 3 forks source link

Expose top level and nested field mask paths #12

Closed johanstokking closed 5 years ago

johanstokking commented 5 years ago

Summary:

Expose top level and nested field mask paths.

What is already there? What do you see now?

It's not exposed. There is a method on each entity that copies the slice.

In my opinion it feels weird making this a method on the entity, as it has nothing to do with the entity nor is it an interface implementation. Also, copying protects against writing, but I don't think we should bother too much about that.

What is missing? What do you want to see?

Expose the top level and nested field mask paths.

How do you propose implementing this?

Remove the prepending _ and the method.