search

TheThingsIndustries / protoc-gen-fieldmask

Generate field mask utilities from proto files
Apache License 2.0
11 stars 3 forks source link

Rewrite modules using templates #23

Open rvolosatovs opened 5 years ago

rvolosatovs commented 5 years ago

Summary:

Modules at modules should be refactored to use templates (https://golang.org/pkg/text/template) instead of using strings.Builder for clarity.

What is already there? What do you see now?

strings.Builder and bunch of Write calls

What is missing? What do you want to see?

Clear templates See https://github.com/lyft/protoc-gen-validate/tree/v0.0.13/templates for an example

How do you propose implementing this?

Rewrite implementations to use templates