TheThingsIndustries / protoc-gen-fieldmask

Generate field mask utilities from proto files
Apache License 2.0
11 stars 3 forks source link

Consider only top-level paths in switch #6

Closed htdvisser closed 5 years ago

htdvisser commented 5 years ago

Summary:

This PR addresses yesterday's discussion about the generated code not being able to properly handle nested paths. This PR should be considered as a way to move forward with MVP until we have a consensus about the goals and implementation of feature/rewrite.

Changes:

rvolosatovs commented 5 years ago

This is already implemented in https://github.com/TheThingsIndustries/protoc-gen-fieldmask/pull/1 without the need for helper functions