search

TheThingsNetwork / arduino-device-lib

Arduino Library for TTN Devices
MIT License
207 stars 96 forks source link

Re-enable test, ignore parentheses #121

Closed FokkeZB closed 7 years ago

FokkeZB commented 7 years ago

DO NOT MERGE

Not all of #119 is resolved yet.

FokkeZB commented 7 years ago

I'll not merge this yet. Will have to fix some other issues of #119 first

FokkeZB commented 7 years ago

Once #144 is merged after https://github.com/TheThingsNetwork/arduino-device-lib/pull/144#pullrequestreview-10230729 has been addressed, this PR should be rebased and merged so that we have CI in place. We can than address the other points from #119 once we get to merge #135.

johanstokking commented 7 years ago

OK, then close the PR and reopen once it's ready to merge.

FokkeZB commented 7 years ago

Once #145 is fixed, this PR can be (rebased and) merged.