search

TheThingsNetwork / arduino-device-lib

Arduino Library for TTN Devices
MIT License
207 stars 96 forks source link

Use correct separator in keywords.txt #227

Closed per1234 closed 6 years ago

per1234 commented 6 years ago

The Arduino IDE requires the use of a tab separator between the name and identifier. Without this tab the keyword is not highlighted.

Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

johanstokking commented 6 years ago

@per1234 thanks, my editor probably converted tabs to spaces.

Can you at least align the keywords, like they were, but then with tabs? Thanks in advance!

per1234 commented 6 years ago

I can do that but the alignment is dependent on the tab size. What is your tab size preference?

johanstokking commented 6 years ago

Thanks. Let's go for 2

per1234 commented 6 years ago

2 makes sense because that's the Arduino default. I did the alignment and then did a squash + force push to keep it to a single commit.