Autobaud, sleep, wake changes

TheThingsNetwork / arduino-device-lib

Arduino Library for TTN Devices

MIT License

208 stars 96 forks source link

Autobaud, sleep, wake changes #234

Open jpmeijers opened 6 years ago

jpmeijers commented 6 years ago

Let's discuss this first before merging.

CLAassistant commented 6 years ago

All committers have signed the CLA.

hallard commented 6 years ago

Thanks for splitting @jpmeijers , looks good to me

johanstokking commented 6 years ago

@hallard can you address @jpmeijers review comments?

johanstokking commented 6 years ago

Hmm, you're approving but I don't see @jpmeijers suggestions implemented.

hallard commented 6 years ago

Well, I'm not an expert of git, @jpmeijers splitted my PR into smaller one and created this one, I thought he was asking for validation, not for implementation. And I'm not sure how to do file changes on a PR from another user.

jpmeijers commented 6 years ago

Yes, I'll make the improvements and come back for feedback. Won't happen that fast though. Perhaps the weekend.

johanstokking commented 6 years ago

@cimm you may want to assist @jpmeijers if wanted!

cimm commented 6 years ago

@johanstokking Happy to help but... I am a software developer, not (yet) a hardware guy. I can see SerialType &modemStream doesn't make sense but I have no idea why we go for a SerialType over a Stream. Simple renaming I can do. :smiley:

Happy to do the work if someone can give me some simple beginner tasks.