search

TheThingsNetwork / arduino-device-lib

Arduino Library for TTN Devices
MIT License
206 stars 96 forks source link

Adding attempts to readLine and state marker if radio module is unres… #244

Closed savnik closed 5 years ago

savnik commented 5 years ago

Proposal to fix issue https://github.com/TheThingsNetwork/arduino-device-lib/issues/242

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

savnik commented 5 years ago

@johanstokking did you have time to review the changes?

savnik commented 5 years ago

So the wait function is implemented. I have tried to make it more clear now. Maybe we do not see the same regarding spacing - but i can not see where the spacing is wrong now?

jpmeijers commented 5 years ago

Only saw the review request now. I'll try and give this PR a proper look and review during the coming week.

ElectronicallyE commented 5 years ago

Thanks guys on making progress on this. I was about to write up an issue about this, but seems like you've got a handle on it already. Would be glad to start using TTN as soon as this is resolved as I have be unable to because of this hanging problem.

johanstokking commented 5 years ago

@jpmeijers good to go now?

savnik commented 5 years ago

@jpmeijers have you had time to take a look at the two changes you sugested?

johanstokking commented 5 years ago

Released in https://github.com/TheThingsNetwork/arduino-device-lib/releases/tag/v2.5.14

Thanks @savnik and @jpmeijers