TheThingsNetwork / arduino-device-lib

Arduino Library for TTN Devices
MIT License
206 stars 96 forks source link

pb.h should be included from the local directory #258

Closed jpmeijers closed 4 years ago

jpmeijers commented 4 years ago

pb.h should be an include from the local directory, therefore #include "ph.h" and not #include <pb.h>.

Compile will fail if this library is not being included from the Arduino global path, but rather from the local directory. For example if the directory structure looks like this:

example/
- example.ino
- src/
-- arduino-device-lib/

and inside example.ino we include the library as follows:

#include "src/arduino-device-lib/src/TheThingsNetwork.h"

After this change the compile is successful.

Note: If the library is present in both the Arduino libraries directory as well as the local directory, compilation might fail due to duplicate definitions. Keep this in mind during testing.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

jpmeijers commented 4 years ago

Strange. Seems like I had to re-authorize the CLA Assistant with Github OAuth2 for it to pick up my previous signed CLA.