initialize the library with a frequency plan

TheThingsNetwork / arduino-device-lib

Arduino Library for TTN Devices

MIT License

208 stars 96 forks source link

initialize the library with a frequency plan #38

Closed n2jn closed 8 years ago

n2jn commented 8 years ago

Initialize the library to TTN_EU868. #32

johanstokking commented 8 years ago

[x] Include US915
[ ] One method for frequency plan that sets power index, data rate (move from reset()), frequencies, channels etc

n2jn commented 8 years ago

@johanstokking ok I didn't see the enableFsbChannels()... Do I also move the dr switch/case from reset() to configure_channels() ?

johanstokking commented 8 years ago

@Nicolasdejean let's keep reset() for resetting ABP and OTAA settings, and configure everything related to the frequency plans in init(): data rates, channels, duty cycles, etc.

n2jn commented 8 years ago

@johanstokking I enable the channels in a loop for EU in configure_EU868 or by calling enableFsbChannels() in configure() for US in configure. Is there an enable loop I forgot ?

johanstokking commented 8 years ago

@FokkeZB @Nicolasdejean why is this PR so big? Should it be rebased?

FokkeZB commented 8 years ago

I guess, this has a lot of commits already in a long time.. 48 commits?! It should be rebased or maybe just re-done one a new branch of off master.