TheThingsNetwork / go-cayenne-lib

CayenneLPP in Go
MIT License
3 stars 6 forks source link

Support UnixTime type for Cayenne LPP #10

Closed arjanmels closed 4 years ago

arjanmels commented 5 years ago

Summary

The Cayenne LPP decoder currently does not support the UnixTime field type (nr 133)

Steps to Reproduce

Send a Cayenne LPP package with UnixTime field

What do you see now?

Cayenne LPP not decoded

What do you want to see instead?

Cayenne LPP properly decoded including timestamp converted to ISO formatted date/time

Environment

Current The Things Network web console

How do you propose to implement this?

pkg/messageprocessors/cayennelpp/cayennelpp.go should add support for UnixTime ...

Can you do this yourself and submit a Pull Request?

Sorry, I am not familiar enough with The Thing Network software stack and the go language.

johanstokking commented 5 years ago

@arjanmels can you provide a source with the specification? I haven't seen it in official comms from MyDevices but I may have missed something.

johanstokking commented 5 years ago

Ah I see it's here under 4.6.

How is this ConfigMask not going to overlap with Channel?

arjanmels commented 4 years ago

@johanstokking It indeed does not seem to be in the MyThings spec. I had my info from the Arduino CayenneLPP library I got via platform.io: Source seems to be: https://github.com/sabas1080/CayenneLPP The 4.6 is a different payload format altogether, instead of just a field in the dynamic payload.

johanstokking commented 4 years ago

@schrein commented that this is a custom field. Since it's not official CayenneLPP, we're not going to support it.

arjanmels commented 4 years ago

@johanstokking Clear. I will handle with custom handler.