search

TheThingsNetwork / go-cayenne-lib

CayenneLPP in Go
MIT License
3 stars 6 forks source link

encoder: change casting for float64 values to handle negative values on ARM #14

Closed deadprogram closed 8 months ago

deadprogram commented 1 year ago

This PR modifies the encoder to change the casting used for float64 values, so it can correctly handle negative values on different architectures than amd64, such as ARM.

This is required in order to handle running Go on ARM processors, as well as for other compilers such as TinyGo, which is specifically where I initially ran into it.

See https://github.com/golang/go/issues/43047 for a description of the underlying Go issue.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

deadprogram commented 1 year ago

Note that this PR is to correct #13

deadprogram commented 1 year ago

Pinging maintainers of this package. Any comments/feedback on this PR? Thanks!

deadprogram commented 1 year ago

Hello, friendly reminder to please complete review of this PR. Thank you!

deadprogram commented 8 months ago

Hello... :smile_cat:

johanstokking commented 8 months ago

Thanks @deadprogram and apologies for the very very late follow up. I'll configure CODEOWNERS here to trigger automatic reviews.

We'll merge it here and update the deps in The Things Stack.

deadprogram commented 8 months ago

Thanks @johanstokking