TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
194 stars 374 forks source link

lorawan-devices Validate Install Dependencies fail #319

Closed Jaime-Trinidad closed 3 years ago

Jaime-Trinidad commented 3 years ago

Summary

Inside lorawan-devices validation, check is failing installing dependencies so Pull Request can't be validated and merged.

What do you see now?

Install dependencies return an exit status 128

pushd ./tools/runscript && go install . && popd ~/work/lorawan-devices/lorawan-devices/tools/runscript ~/work/lorawan-devices/lorawan-devices go: go.thethings.network/lorawan-stack/v3@v3.14.0 requires github.com/chrj/smtpd@v0.1.2 requires github.com/eaigner/dkim@v0.0.0-20150301120808-6fe4a7ee9cfb: invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/runner/go/pkg/mod/cache/vcs/b1a9951edebf25b789a34398ad65880e06631bf718a381c881083257167b44d8: exit status 128: fatal: could not read Username for 'https://github.com': terminal prompts disabled make: *** [Makefile:28: deps] Error 1 Error: Process completed with exit code 2.

What do you want to see instead?

Install dependencies correctly so it can run validate to PRs

How do you propose to implement this?

Reading maybe some ssh instead of https keys, but not sure.

Can you do this yourself and submit a Pull Request?

No, I can test.

Jaime-Trinidad commented 3 years ago

It looks like one dependency was deleted by the author https://github.com/eaigner/dki doesn't exist anymore.

johanstokking commented 3 years ago

Yeah the repo is gone. The Things Stack depends on this.

We need to sort this out upstream.