TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
194 stars 374 forks source link

Add reviewer guides #33

Closed johanstokking closed 1 year ago

johanstokking commented 3 years ago

Summary

Add guides for reviewers

Why do we need this?

For community reviewers to have clear guidelines that they can apply when reviewing pull requests from the device maker community.

What is already there? What do you see now?

Contributing guidelines

What is missing? What do you want to see?

Guidelines on what to check, suggesting:

How do you propose to implement this?

Can you do this yourself and submit a Pull Request?

Yes

johanstokking commented 3 years ago

@Jaime-Trinidad please take the lead here.

Looping in @nejraselimovic for alignment with TTN and TTS docs.

NicolasMrad commented 1 year ago

Is this still relevant? If so, how can we move forward?

johanstokking commented 1 year ago

We probably don't need this anymore.