search

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
194 stars 376 forks source link

New vendor - SmartRural #546

Closed SR-Crooks closed 1 year ago

SR-Crooks commented 2 years ago

New vendor - SmartRural

Summary

...

Changes

None.

Notes for Reviewers

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

SR-Crooks commented 2 years ago

Sorry, I missed that. Thanks for the heads up. It’s been signed now. 😊

From: Jaime Trinidad @.> Sent: 31 October 2022 13:28 To: TheThingsNetwork/lorawan-devices @.> Cc: Paul Crooks @.>; Mention @.> Subject: Re: [TheThingsNetwork/lorawan-devices] New vendor - SmartRural (PR #546)

Hi @SR-Crookshttps://github.com/SR-Crooks please sign the CLA

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/546#issuecomment-1297091553, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A334PGT76KXTGXU4DEZBUZDWF7CNVANCNFSM6AAAAAARS6JVFM. You are receiving this because you were mentioned.Message ID: @.**@.>>

SR-Crooks commented 1 year ago

Hi, I really dont mean this to come off the wrong way and apologies if this has been asked or stated somewhere else but is there a particular time frame for pull requests being reviewed i.e. every 2 weeks or on certain days? The first (failed 😣) request I put was reviewed so quick and this one has been sitting for some time now.

Jaime-Trinidad commented 1 year ago

Hi @SR-Crooks thanks for adding your device, I have to fix my commit and I merge it

johanstokking commented 1 year ago

@SR-Crooks as the requested changes are so minimal I decided to address them. No functional changes. Thanks for your contribution!

SR-Crooks commented 1 year ago

Thanks so much! 😊 I had intended to make the changes; I’ve just been flat out at work.

From: Johan Stokking @.> Sent: 29 November 2022 10:31 To: TheThingsNetwork/lorawan-devices @.> Cc: Paul Crooks @.>; Mention @.> Subject: Re: [TheThingsNetwork/lorawan-devices] New vendor - SmartRural (PR #546)

@SR-Crookshttps://github.com/SR-Crooks as the requested changes are so minimal I decided to address them. No functional changes. Thanks for your contribution!

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/546#issuecomment-1330415889, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A334PGUFJYLQEHB7HNJMBY3WKXLN7ANCNFSM6AAAAAARS6JVFM. You are receiving this because you were mentioned.Message ID: @.**@.>>