Closed Kway99 closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Hi,
This is Lee from Seeed SenseCAP team. Recently we launched a new product S2120-8-in-1 weather sensor. Could you please update the device to the TTN platform? Meanwhile, we made some changes to the decoder file of the S2100 Data Logger. We sincerely wish you'll approve this pull request and if there are any problems, please feel free to leave a message here. Many thanks for your attention and also thanks for the video 'how to add the device'. That's really helpful. Hope you know we do value our future collaboration opportunities~
Best Regards
Hi @Kway99 thanks for adding the device, some comments:
-Sign CLA
-In the files do not overwrite on existing profiles sensecap-profile.yaml
you change 'MAC version` from 1.0.2 to 1.0.3, this change can affect existing devices connected, please add a new profile with version 1.0.3.
Summary
...
Changes
Notes for Reviewers
Hi,
This is Lee from Seeed SenseCAP team. Recently we launched a new product S2120-8-in-1 weather sensor. Could you please update the device to the TTN platform? Meanwhile, we made some changes to the decoder file of the S2100 Data Logger. We sincerely wish you'll approve this pull request and if there are any problems, please feel free to leave a message here. Many thanks for your attention and also thanks for the video 'how to add the device'. That's really helpful. Hope you know we do value our future collaboration opportunities~
Best Regards
Release Notes