Added elv-lw-esi and elv-lw-gps1 to incex.yaml, changed image of elv-bm-trx1 and flipped shop urls

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices

Apache License 2.0

192 stars 370 forks source link

Added elv-lw-esi and elv-lw-gps1 to incex.yaml, changed image of elv-bm-trx1 and flipped shop urls #570

Closed ELV-Elektronik-AG closed 1 year ago

ELV-Elektronik-AG commented 1 year ago

Summary

...

Changes

added elv-lw-esi
added elv-lw-gps1
changed image of elv-bm-trx1
flipped urls in elv-bm-trx1.yaml

Notes for Reviewers

...

Release Notes

CLAassistant commented 1 year ago

All committers have signed the CLA.

ELV-Elektronik-AG commented 1 year ago

Hello, i changed some details in the files of our devices, but i noticed that the command 'make validate fmt' returns an error in an other devices folder (vendor/cital/lorasoil.js). Also i still have problems with the CLA and i don't know how to fix it by myself. I appreciate any help regarding this topic.

Jaime-Trinidad commented 1 year ago

Hi @ELV-Elektronik-AG the CLA can be the mail that you use, you only need to add the mail to the commit, check if this works

Jaime-Trinidad commented 1 year ago

Hello, i changed some details in the files of our devices, but i noticed that the command 'make validate fmt' returns an error in an other devices folder (vendor/cital/lorasoil.js). Also i still have problems with the CLA and i don't know how to fix it by myself. I appreciate any help regarding this topic.

I fix it and now your PR is ready to merge, only missing the CLA, check my comment. Thanks