Closed jabeurj closed 1 year ago
Hi @jabeurj thanks for adding the devices, please sign the CLA
Hello, I'm sorry I didn't see the comment to sign the CLA in time. Can I do a new pull request please? Thank you
@jabeurj Thanks for adding the devices is great, only two comments:
Hello, I'm sorry I didn't see the comment to sign the CLA in time. Can I do a new pull request please? Thank you
I think is no necessary try to sign this PR
Hello, I'm sorry I didn't see the comment to sign the CLA in time. Can I do a new pull request please? Thank you
Sure, I will do it tomorrow and push again. Thanks a lot.
@jabeurj your last commit here changes all files, most likely the line endings (?). The other commits are good.
We can fix the commit signing issue if you can share the email address here that is associated with your GitHub account? We can set the commit author to that email address so GitHub associates it with your account, and our CLA bot detects it correctly.
@jabeurj Thanks for adding the devices is great, only two comments:
- Are you able to upload images without background? The devices will automatically deploy in Devices page, to keep format It's done for the images. Thank you
your last commit here changes all files, most likely the line endings (?). The other commits are good. Oh Sorry. I will see how i can fix that. We can fix the commit signing issue if you can share the email address here that is associated with your GitHub account? We can set the commit author to that email address so GitHub associates it with your account, and our CLA bot detects it correctly. my email address : jaafar.jabeur@gmail.com
Thanks @jabeurj !
There's a file referenced which doesn't exist:
Error: ENOENT: no such file or directory, open './vendor/fludia/fm432g.jpg'
at Object.openSync (node:fs:590:3)
at Function.module.exports.sync (/home/runner/work/lorawan-devices/lorawan-devices/node_modules/with-open-file/index.js:19:17)
at Function.module.exports.sync (/home/runner/work/lorawan-devices/lorawan-devices/node_modules/read-chunk/index.js:30:33)
at /home/runner/work/lorawan-devices/lorawan-devices/bin/validate.js:153:30
at new Promise (<anonymous>)
at validateImageExtension (/home/runner/work/lorawan-devices/lorawan-devices/bin/validate.js:152:10)
at /home/runner/work/lorawan-devices/lorawan-devices/bin/validate.js:294:15
at Array.forEach (<anonymous>)
at /home/runner/work/lorawan-devices/lorawan-devices/bin/validate.js:222:23
at FSReqCallback.oncomplete (node:fs:203:5) {
errno: -2,
syscall: 'open',
code: 'ENOENT',
path: './vendor/fludia/fm432g.jpg'
You should be able to test validation locally with make validate
.
@jabeurj I'm afraid this doesn't work; we require lowercase filenames. Can you rename the file to lowercase? You can do this with git mv
.
Summary
No issues only adding our devices.
Changes
Notes for Reviewers
...
Release Notes