search

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
192 stars 370 forks source link

Update ATIM decodeur #602

Closed HESSjulien closed 1 year ago

HESSjulien commented 1 year ago

Summary

Hello,

I am Julien HESS from the company ATIM. I made the update of codecs so that they are compatible on the TTN platform.

I thank you in advance.

Changes

Notes for Reviewers

...

Release Notes

Jaime-Trinidad commented 1 year ago

Hi @HESSjulien please change the file name decodeur_TTN.js it need to be lowercase, also change _ from the name, and modify in the codec files where you are using this decoder

HESSjulien commented 1 year ago

Thank you,

After solving this problem, I had a new problem that I indicated on the first email.

I can't solve this problem.

De : Jaime Trinidad @.> Envoyé : jeudi 13 avril 2023 16:16 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602)

Hi @HESSjulienhttps://github.com/HESSjulien please change the file name decodeurTTN.js it needs to be lowercase, also change from the name, and modify in the codec files where you are using this decoder

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/602#issuecomment-1507051050, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QISCNYIX66H7WJA3ILXBADELANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>

Jaime-Trinidad commented 1 year ago

Thank you, After solving this problem, I had a new problem that I indicated on the first email. I can't solve this problem. … ____ De : Jaime Trinidad @.> Envoyé : jeudi 13 avril 2023 16:16 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602) Hi @HESSjulienhttps://github.com/HESSjulien please change the file name decodeurTTN.js it needs to be lowercase, also change from the name, and modify in the codec files where you are using this decoder — Reply to this email directly, view it on GitHub<#602 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QISCNYIX66H7WJA3ILXBADELANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>

Yo still have the problem with the image? same image as the one you sent? I ran both make and there is no issue

HESSjulien commented 1 year ago

Yes exactly,

I don't know where the problem comes from. Is there any other solution to modify my codecs ?

De : Jaime Trinidad @.> Envoyé : jeudi 13 avril 2023 16:27 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602)

Thank you, After solving this problem, I had a new problem that I indicated on the first email. I can't solve this problem. … ____ De : Jaime Trinidad @.> Envoyé : jeudi 13 avril 2023 16:16 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602https://github.com/TheThingsNetwork/lorawan-devices/pull/602) Hi @HESSjulienhttps://github.com/HESSjulienhttps://github.com/HESSjulien please change the file name decodeurTTN.js it needs to be lowercase, also change from the name, and modify in the codec files where you are using this decoder — Reply to this email directly, view it on GitHub<#602 (comment)https://github.com/TheThingsNetwork/lorawan-devices/pull/602#issuecomment-1507051050>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QISCNYIX66H7WJA3ILXBADELANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>

Yo still have the problem with the image? same image as the one you sent? I ran both make and there is no issue

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/602#issuecomment-1507069632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QMZYZOQAHGZ4IGSQI3XBAEOHANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>

johanstokking commented 1 year ago

@HESSjulien please revert the changes to files other than vendor/atim/*.

johanstokking commented 1 year ago

What is the issue that you have remaining?

HESSjulien commented 1 year ago

normally, I have not modified anything except the vendor/ATIM file. I still have the same problem, when I do a "$ make validate fmt" it gives me an error on the image catena4612.png of the vendor mcci. See the image in attachment.

De : Johan Stokking @.> Envoyé : vendredi 14 avril 2023 11:37 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602)

What is the issue that you have remaining?

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/602#issuecomment-1508233886, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QLGDHYKOQMB7F5CBT3XBELFVANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>

HESSjulien commented 1 year ago

De : Julien Hess @.> Envoyé : vendredi 14 avril 2023 12:26 À : TheThingsNetwork/lorawan-devices @.> Objet : RE: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602)

normally, I have not modified anything except the vendor/ATIM file. I still have the same problem, when I do a "$ make validate fmt" it gives me an error on the image catena4612.png of the vendor mcci. See the image in attachment.

De : Johan Stokking @.> Envoyé : vendredi 14 avril 2023 11:37 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602)

What is the issue that you have remaining?

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/602#issuecomment-1508233886, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QLGDHYKOQMB7F5CBT3XBELFVANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>

johanstokking commented 1 year ago

You probably don't have the right Node.js version installed; please check with node -v, see also README.

We don't see email attachments here; please copy the error message as text.

HESSjulien commented 1 year ago

Hello,

I'm so sorry, i can't install good node and npm version. I have lot a problem. Is there any other solution to change the documents please ?

I'm very sorry.

De : Johan Stokking @.> Envoyé : lundi 17 avril 2023 16:09 À : TheThingsNetwork/lorawan-devices @.> Cc : Julien Hess @.>; Mention @.> Objet : Re: [TheThingsNetwork/lorawan-devices] Update ATIM decodeur (PR #602)

You probably don't have the right Node.js version installed; please check with node -v, see also README.

We don't see email attachments here; please copy the error message as text.

— Reply to this email directly, view it on GitHubhttps://github.com/TheThingsNetwork/lorawan-devices/pull/602#issuecomment-1511427912, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GK4QJOYEV5R4PTRJREDV3XBVFJLANCNFSM6AAAAAAW5C4N3U. You are receiving this because you were mentioned.Message ID: @.***>