Added Lualtek swsi device

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices

Apache License 2.0

191 stars 367 forks source link

Added Lualtek swsi device #607

Closed LasaleFamine closed 8 months ago

LasaleFamine commented 1 year ago

Summary

Adding new vendor device by Lualtek into the device repository

Changes

added vendor/lualtek
modified vendor/index.yml

CLAassistant commented 1 year ago

All committers have signed the CLA.

LasaleFamine commented 1 year ago

Hello @Jaime-Trinidad is there some sort of ETA that we should wait every time we open a PR? Because I have other devices to add and I want to understand if it's better to open a PR with everything inside (although it would be more difficult to review...). Thanks!

Jaime-Trinidad commented 1 year ago

hey @LasaleFamine thanks for the update, please review the error that your files gives in the class C, and run validation commands again

LasaleFamine commented 1 year ago

@Jaime-Trinidad I had a problem on the validate command that didn't run properly in local. Now it should be ok. Sorry for the inconvenient.

LasaleFamine commented 1 year ago

@Jaime-Trinidad sorry for bothering, just want to test if this works so I can open a new PR with other devices. Are there any news? Thanks!

Jaime-Trinidad commented 1 year ago

Hi @LasaleFamine now it looks it runs properly, I can't update so, can you update it, I will wait you to do it, so I can merge it, thanks

LasaleFamine commented 1 year ago

@Jaime-Trinidad done!

Jaime-Trinidad commented 1 year ago

Hi @LasaleFamine there is an error in the validation, can you check the codec file:

lualtek: lualtek-swsi: EU863-870: payload codec lualtek-swsi-codec invalid Error: Command failed: bin/runscript -codec-path "./vendor/lualtek/lualtek-swsi.js" -routine encodeDownlink -input '{"data":{"switchValue":0}}' 2023/06/07 09:41:33 Marshal output: json: unsupported value: NaN

LasaleFamine commented 1 year ago

Hi @Jaime-Trinidad it's been a bit frustrating since locally I don't see any error when running the validation. Also seems like the validation script just spawns a lot of processes that sometimes crushes my Mac. I think I will remove that part from the codec directly since I cannot test it with ease.

LasaleFamine commented 10 months ago

Hello @Jaime-Trinidad are there any news for this one?

Jaime-Trinidad commented 8 months ago

Hi @LasaleFamine we replicated the PR and we already merge it, it will be in the next release of TTS, I will close this PR

LasaleFamine commented 8 months ago

@Jaime-Trinidad that's awesome! Sorry for not being able to fix it as per CI.

I will try to emulate yours for new devices. Thanks!