TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
191 stars 367 forks source link

Add SENSO8 LoRaWAN sensors #610

Closed arthur-arwin closed 11 months ago

arthur-arwin commented 1 year ago

Summary

Add SENSO8 LoRaWAN sensors, including temperature/humidity, water leak and open close contact sensor.

Changes

Notes for Reviewers

...

Release Notes

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

Jaime-Trinidad commented 1 year ago

@arthur-arwin thanks for adding your device, please run make deps don't modify package-lock file

arthur-arwin commented 1 year ago

@Jaime-Trinidad I've made the changes.

arthur-arwin commented 1 year ago

@Jaime-Trinidad any further action required on our side?

Jaime-Trinidad commented 1 year ago

@arthur-arwin can you resolve the conflicts in your files please

arthur-arwin commented 1 year ago

@arthur-arwin can you resolve the conflicts in your files please

@Jaime-Trinidad I've resolved the conflicts. Any further action required from me?

Jaime-Trinidad commented 1 year ago

Hi @arthur-arwin there is still one error in lrs20100-codec.yaml dataUploadInterval output is 3840 you can check it running bin/runscript -codec-path "./vendor/arwin-technology/lrs20100.js" -routine decodeUplink -input '{"fPort":12,"bytes":[1,0,15,0,1]}'

arthur-arwin commented 1 year ago

Hi @arthur-arwin there is still one error in lrs20100-codec.yaml dataUploadInterval output is 3840 you can check it running bin/runscript -codec-path "./vendor/arwin-technology/lrs20100.js" -routine decodeUplink -input '{"fPort":12,"bytes":[1,0,15,0,1]}'

I've fixed the error and passed 'make validate'. Thanks!

arthur-arwin commented 1 year ago

Hi @arthur-arwin there is still one error in lrs20100-codec.yaml dataUploadInterval output is 3840 you can check it running bin/runscript -codec-path "./vendor/arwin-technology/lrs20100.js" -routine decodeUplink -input '{"fPort":12,"bytes":[1,0,15,0,1]}'

@Jaime-Trinidad I've fixed the error and passed 'make validate'. Thanks!

arthur-arwin commented 1 year ago

@Jaime-Trinidad We have fixed the codes blocking the checks. Any further action required from us?

arthur-arwin commented 11 months ago

No idea how to resolve and cannot proceed with the merge.