TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
191 stars 367 forks source link

BMETER HYDRODIGIT #624

Closed IkerBA closed 6 months ago

IkerBA commented 1 year ago

Summary

VIF parameter wrongly detected for hectoliters, same value as liters.

What do you see now?

//liters if (input.bytes[11] === 0x0D) { data.vif = input.bytes[11]1; } //decaliters else if (input.bytes[11] === 0x0E){ data.vif = input.bytes[11]10; } //hectoliters else if(input.bytes[11] === 0x0D){ data.vif = input.bytes[11]*100;

What do you want to see instead?

//liters if (input.bytes[11] === 0x0D) { data.vif = input.bytes[11]1; } //decaliters else if (input.bytes[11] === 0x0E){ data.vif = input.bytes[11]10; } //hectoliters else if(input.bytes[11] === 0x0F){ data.vif = input.bytes[11]*100;

How do you propose to implement this?

Modify hectoliters detection

Can you do this yourself and submit a Pull Request?

No

NicolasMrad commented 1 year ago

@Jaime-Trinidad is this something you can check?

IkerBA commented 10 months ago

Data is sent as DEC numbers, not HEX so 2⁸ conversion is not right and must be picked decimals numbers as sent in the datagram.

Jaime-Trinidad commented 6 months ago

Decoder file is now fixed