search

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
184 stars 361 forks source link

Add elspina vendor and em-elst01 device #668

Closed BrittaHhm closed 4 months ago

BrittaHhm commented 10 months ago

Summary

Add vendor elspina and device em-elst01

Changes

Notes for Reviewers

...

Release Notes

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

BrittaHhm commented 9 months ago

@Jaime-Trinidad - Could you please tell us what we need to fix so the pull request can be closed?

Jaime-Trinidad commented 9 months ago

Hi @BrittaHhm can you review your decoder and codec file, name the functiondecodeUplinkand check the output in codec example

Jaime-Trinidad commented 9 months ago

Hi @BrittaHhm there is still an error in em-elst01-codec.yaml the output of the second example does not fit, you need to check your decoder .js file so it is well handled:

./bin/runscript -codec-path "vendor/elspina/em-elst01.js" -routine decodeUplink -input '{"fPort":42,"bytes":["0x0D", "0x48", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0xFF", "0xF5", "0xFF", "0xC6", "0x03", "0x9D", "0x01", "0x00"]}'

Output {"ALARM":"0x00","Bat":3.4,"LDOD":0,"TNOMD":0,"TODE":0,"X":"-0.10","Y":"-0.57","Z":"9.25","status":0,"temp_ds":"25.6"} expected output = errors: unknown Fport