search

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices
Apache License 2.0
184 stars 360 forks source link

Add r718pa,r718pa4,r718pb,rp02,r718n3 support #718

Closed netvox-tech closed 1 month ago

netvox-tech commented 7 months ago

Add r718pa,r718pa4,r718pb,rp02,r718n3 support

Jaime-Trinidad commented 7 months ago

hi @netvox-tech this PR is the same as #717 which one is the one to review?

netvox-tech commented 7 months ago

Dear Sir,

please review #718. Thank you.

On Thu, 07 Dec 2023 04:31:35 -0800, Jaime Trinidad wrote

hi @netvox-tech this PR is the same as #717 which one is the one to review?

-- Reply to this email directly or view it on GitHub: https://github.com/TheThingsNetwork/lorawan-devices/pull/718#issuecomment-1845261968 You are receiving this because you were mentioned.

Message ID: @.***> -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

-- Regards......your name (http://www.netvox.com.tw)

-- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

Jaime-Trinidad commented 6 months ago

@netvox-tech please add images of the devices, when we merge it the information will be deployed https://www.thethingsnetwork.org/device-repository/ without background please

Jaime-Trinidad commented 6 months ago

@netvox-tech any update?

LDannijs commented 3 months ago

@netvox-tech any update here?

netvox-tech commented 2 months ago

You said it was approved, then you mentioned missing images, and finally you mentioned conflicts. So what was the final situation?

LDannijs commented 2 months ago

The situation is that it's missing images. Please add those and then it should be good.

LDannijs commented 2 months ago

@netvox-tech Could you please still add the images so that we can approve of this PR?

netvox-tech commented 2 months ago

@LDannijs

We had added images for these devices as below pull request. image Would you please tell us which one we missed?

LDannijs commented 1 month ago

@netvox-tech I had not expected you to make a seperate PR for the images.

I see all the files from this PR are in the DR now, so can we close this one?

LDannijs commented 1 month ago

From what i can see these files are added in the repo with the other PRs, closing this.