Adding new Device - Githubissues

TheThingsNetwork / lorawan-devices

Device Repository for LoRaWAN devices

Apache License 2.0

183 stars 360 forks source link

Adding new Device #791

Closed GiorgosM1995 closed 2 weeks ago

GiorgosM1995 commented 1 month ago

Summary

...

Changes

Checklist for Reviewers

[x] Title and description should be descriptive (Not just a serial number for example).
[x] profileIDs should not be vendorID and should be a unique value for every profile.
[x] All devices should be listed in the vendor's index.yaml file.
[x] Firmware versions can not be changed.
[x] At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

CLAassistant commented 1 month ago

All committers have signed the CLA.

LDannijs commented 1 month ago

You've not yet ran make validate fmt, i still see some issues. Please make sure to read our README on how to do it: https://github.com/TheThingsNetwork/lorawan-devices?tab=readme-ov-file#prerequisites

LDannijs commented 1 month ago

Please run make validate fmt until there are no more errors that show up.

LDannijs commented 1 month ago

Thank you! My colleague @Jaime-Trinidad will merge it when he looks at it.

LDannijs commented 1 month ago

I am seeing some prettier issues still. Please make sure you have read our README and make sure you run make validate fmt every time you want to push changes.

GiorgosM1995 commented 1 month ago

I cannot run make validate fmt gives me this error : -z was unexpected at this time. make: *** [Makefile:41: validate] Error 255

LDannijs commented 1 month ago

Have you made sure you have installed:

Node.js version 16.x (This is recommended, as newer versions may give errors)
npm version 8.x
Go version 1.18.x

and ran make deps? https://github.com/TheThingsNetwork/lorawan-devices?tab=readme-ov-file#prerequisites

GiorgosM1995 commented 1 month ago

I had a newer version of Node i am installing the one you said me and i am trying again

GiorgosM1995 commented 1 month ago

make deps give me this error : pushd ./tools/runscript && go install . && popd The syntax of the command is incorrect. make: *** [Makefile:31: deps] Error 1

Also make validate fmt: -z was unexpected at this time. make: *** [Makefile:41: validate] Error 255mak

LDannijs commented 1 month ago

May i ask what operating system you are using?

GiorgosM1995 commented 1 month ago

Edition: Windows 10 Home Version: 22h2 OS build: 19045.4412

LDannijs commented 1 month ago

As i suspected. Have you installed Windows Subsystem for Linux (WSL)? If not, install that or install linux (on a VM is possible)

GiorgosM1995 commented 1 month ago

Hello again i install the wsl and Prerequisites but now gives me this error: make deps npm install /usr/bin/node: 1: ELF: not found /usr/bin/node: 2: : not found /usr/bin/node: 2: Syntax error: word unexpected (expecting ")") make: *** [Makefile:30: deps] Error 2

LDannijs commented 1 month ago

Have you made sure you are using node 16? try node -v

LDannijs commented 1 month ago

Everything looks good now, thanks! My colleague will merge it when he gets to it.