Create convert-to-json.yml

TheThingsNetwork / lorawan-frequency-plans

LoRaWAN Frequency Plans for The Things Stack

https://www.thethingsnetwork.org

Apache License 2.0

35 stars 26 forks source link

Create convert-to-json.yml #21

Closed benolayinka closed 4 years ago

benolayinka commented 4 years ago

Summary

Generate json from yml

Changes

Github action to create json from frequency-plans.yml

Notes for Reviewers

...

Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[ ] Compatibility: The changes are backwards compatible, they don't break existing deployments.
[ ] Testing: The changes are tested.
[ ] Documentation: Relevant documentation is added or updated.

benolayinka commented 4 years ago

I think this won't work anyway. It saves the json as a build artifact, but to actually commit the file it would need to be able to push directly to master

https://github.community/t5/GitHub-Actions/Can-GitHub-actions-directly-edit-files-in-a-repository/td-p/50551

benolayinka commented 4 years ago

This is blocking https://github.com/TheThingsNetwork/lorawan-stack/pull/2562

@johanstokking do you have a good idea how to make this flow work, using gh actions? My action won't work because I don't know how to push to master

johanstokking commented 4 years ago

@johanstokking do you have a good idea how to make this flow work, using gh actions? My action won't work because I don't know how to push to master

In the link you referenced there are instructions to push to master right?

benolayinka commented 4 years ago

@johanstokking do you have a good idea how to make this flow work, using gh actions? My action won't work because I don't know how to push to master

In the link you referenced there are instructions to push to master right? I don't have permission to commit directly to master.

@johanstokking do you have a good idea how to make this flow work, using gh actions? My action won't work because I don't know how to push to master

In the link you referenced there are instructions to push to master right?

Yep but the action doesn't have permission to push directly to the master branch

benolayinka commented 4 years ago

Do we really need to do this as a Github Action? Can't we just ask contributors to run make generate or something, like we ask them to do in TheThingsNetwork/lorawan-stack?

What's the advantage of doing it manually vs automatically?

htdvisser commented 4 years ago

The advantage of doing it manually before submitting the pull request is that we can verify in the pull request that it's okay, and that we don't have to disable branch protections

benolayinka commented 4 years ago

The advantage of doing it manually before submitting the pull request is that we can verify in the pull request that it's okay, and that we don't have to disable branch protections

Maybe I can just push the file to another branch and read it from there

johanstokking commented 4 years ago

The volatility in this repo is minimal anyway, so asking people to run a generation command before their PR checks are green is also a good solution imo.

benolayinka commented 4 years ago

The volatility in this repo is minimal anyway, so asking people to run a generation command before their PR checks are green is also a good solution imo.

Closing, for now we will just pull the file as part of ./mage docs:deps https://github.com/TheThingsNetwork/lorawan-stack/pull/2562#issuecomment-638879658