Create AS_920_923_TTN_VN

viethoa14 commented 3 years ago

Create two frequency default 921.4 and 921.6 for frequency plan, rx2 default use datarate 2(sf10)

Summary

band-id: AS_923 sub-bands:

min-frequency: 920000000 max-frequency: 923000000 duty-cycle: 0.01 # Duty cycle for this sub-band (optional; default: 1) max-eirp: 16 uplink-channels:
frequency: 921400000 min-data-rate: 0 max-data-rate: 5 radio: 0
frequency: 921600000 min-data-rate: 0 max-data-rate: 5 radio: 0
frequency: 921800000 min-data-rate: 0 max-data-rate: 5 radio: 0
frequency: 922000000 min-data-rate: 0 max-data-rate: 5 radio: 0
frequency: 922200000 min-data-rate: 0 max-data-rate: 5 radio: 0
frequency: 922400000 min-data-rate: 0 max-data-rate: 5 radio: 1
frequency: 922600000 min-data-rate: 0 max-data-rate: 5 radio: 1
frequency: 922800000 min-data-rate: 0 max-data-rate: 5 radio: 1 downlink-channels:
frequency: 921400000 min-data-rate: 0 max-data-rate: 5
frequency: 921600000 min-data-rate: 0 max-data-rate: 5
frequency: 921800000 min-data-rate: 0 max-data-rate: 5
frequency: 922000000 min-data-rate: 0 max-data-rate: 5
frequency: 922200000 min-data-rate: 0 max-data-rate: 5
frequency: 922400000 min-data-rate: 0 max-data-rate: 5
frequency: 922600000 min-data-rate: 0 max-data-rate: 5
frequency: 922800000 min-data-rate: 0 max-data-rate: 5

lora-standard-channel: frequency: 923000000 data-rate: 6 radio: 1

fsk-channel:

frequency: 921200000

data-rate: 7

radio: 0

radios:
enable: true chip-type: SX1257 frequency: 921800000 rssi-offset: -166 tx: min-frequency: 920000000 max-frequency: 923000000
enable: true chip-type: SX1257 frequency: 922800000 rssi-offset: -166 clock-source: 1 rx2-channel: # Rx2 channel (optional) frequency: 921400000 min-data-rate: 0 max-data-rate: 5 radio: 0 rx2-default-data-rate: 2 # Default data rate index of Rx2 (optional) max-eirp: 16

Changes

...
...

Notes for Reviewers

...

Checklist

[ ] Scope: The referenced issue is addressed, there are no unrelated changes.
[ ] Compatibility: The changes are backwards compatible, they don't break existing deployments.
[ ] Testing: The changes are tested.
[ ] Documentation: Relevant documentation is added or updated.

johanstokking commented 3 years ago

@viethoa14 thanks. Can you also update the index?

viethoa14 commented 3 years ago

thanks for your support! We just edit index. No need upload new file and new request, right?

htdvisser commented 3 years ago

This looks good to me, however I would propose that we rename this channel plan to AS923_2_TTN, because it's basically the AS923 (Group 2) plan (see https://github.com/TheThingsNetwork/lorawan-frequency-plans/pull/32) with additional channels. In that plan, we'd the EIRP limits at their defaults.

We'd then create a separate _VN config that extends that AS923_2_TTN plan with a different EIRP limit, similar to what we've done with AS_920_923_TTN_AU.

htdvisser commented 3 years ago

Oh and in line with my other Pull Requests, here's the picture for the proposed AS_920_923_TTN_VN:

AS_920_923_TTN_VN yml

htdvisser commented 3 years ago

Similar to what I just commented in #32, this plan should work fine for gateways now, but we'll need https://github.com/TheThingsNetwork/lorawan-stack/issues/3513 for this to work correctly for end devices, so I'm afraid we'll need to block this until that is fixed, otherwise I'm afraid we'll have some weird behavior with joins and RX2 downlinks.

IoTThinks commented 3 years ago

This one should be AS923-2? I'm eager to see AS923-2 working for 920-923Mhz (<= 923Mhz) and get it synced with other LoRaWAN gateway and node vendors.

htdvisser commented 3 years ago

As https://github.com/TheThingsNetwork/lorawan-stack/issues/3513 was pushed to v3.14, this will have to be pushed as well.

TheThingsNetwork / lorawan-frequency-plans