Closed adriansmares closed 2 years ago
References https://github.com/TheThingsNetwork/lorawan-frequency-plans/pull/48
The lack of duration fails the validation: https://github.com/TheThingsNetwork/lorawan-stack/blob/9d58a370c158a60072ed841370a5e7a97b67f419/pkg/frequencyplans/frequencyplans.go#L429-L431 During my tests I only verified that disabling works, which was not enough.
I will add CI checks as part of https://github.com/TheThingsNetwork/lorawan-frequency-plans/issues/38 which will catch these issues in the future.
Summary
References https://github.com/TheThingsNetwork/lorawan-frequency-plans/pull/48
Changes
Notes for Reviewers
The lack of duration fails the validation: https://github.com/TheThingsNetwork/lorawan-stack/blob/9d58a370c158a60072ed841370a5e7a97b67f419/pkg/frequencyplans/frequencyplans.go#L429-L431 During my tests I only verified that disabling works, which was not enough.
I will add CI checks as part of https://github.com/TheThingsNetwork/lorawan-frequency-plans/issues/38 which will catch these issues in the future.
Checklist