TheThingsNetwork / lorawan-frequency-plans

LoRaWAN Frequency Plans for The Things Stack
https://www.thethingsnetwork.org
Apache License 2.0
35 stars 26 forks source link

Explicitly add the dwell time duration #49

Closed adriansmares closed 2 years ago

adriansmares commented 2 years ago

Summary

References https://github.com/TheThingsNetwork/lorawan-frequency-plans/pull/48

Changes

Notes for Reviewers

The lack of duration fails the validation: https://github.com/TheThingsNetwork/lorawan-stack/blob/9d58a370c158a60072ed841370a5e7a97b67f419/pkg/frequencyplans/frequencyplans.go#L429-L431 During my tests I only verified that disabling works, which was not enough.

I will add CI checks as part of https://github.com/TheThingsNetwork/lorawan-frequency-plans/issues/38 which will catch these issues in the future.

Checklist