Closed reissjason closed 2 years ago
Same issue is seen in AS_920_923_TTN_JP_1 AS_920_923_TTN_JP_2 has similar issue with lora-standard-channel definition.
I ran a script to test for frequencies more than 400KHz off the radio frequency. The other plans look OK. The JP_1 plan has a few possible errors.
INVALID CHANNEL AS_920_923_TTN_JP_2.yml DIFF: -1000000 {'frequency': 922100000, 'data-rate': 6, 'radio': 1} {'enable': True, 'chip-type': 'SX1257', 'frequency': 923100000, 'rssi-offset': -166}
INVALID CHANNEL AS_920_923_TTN_JP_1.yml DIFF: -500000 {'frequency': 922000000, 'min-data-rate': 0, 'max-data-rate': 5, 'radio': 0} {'enable': True, 'chip-type': 'SX1257', 'frequency': 922500000, 'rssi-offset': -166, 'tx': {'min-frequency': 922000000, 'max-frequency': 923400000}} INVALID CHANNEL AS_920_923_TTN_JP_1.yml DIFF: -1000000 {'frequency': 922100000, 'data-rate': 6, 'radio': 1} {'enable': True, 'chip-type': 'SX1257', 'frequency': 923100000, 'rssi-offset': -166} INVALID CHANNEL AS_920_923_TTN_JP_1.yml DIFF: -1300000 {'frequency': 921800000, 'data-rate': 7, 'radio': 1} {'enable': True, 'chip-type': 'SX1257', 'frequency': 923100000, 'rssi-offset': -166}
INVALID CHANNEL AS_920_923_TTN_JP_3.yml DIFF: 1000000 {'frequency': 922700000, 'data-rate': 7, 'radio': 1} {'enable': True, 'chip-type': 'SX1257', 'frequency': 921700000, 'rssi-offset': -166}
Summary
Invalid radio settings issued by AS_920_923_TTN_JP_3
https://github.com/TheThingsNetwork/lorawan-frequency-plans/blob/9313b1ac0262da74f4f23f9e87aaa1234c468697/AS_920_923_TTN_JP_3.yml#L69
A channel cannot be more than +/- 400 KHz from the radio frequency. ...
Environment
Steps to Reproduce
What do you see now?
...
What do you want to see instead?
The basic station should be able to run, invalid configuration should not be provided. ...
How do you propose to implement this?
A different frequency needs to be defined. ...
Can you do this yourself and submit a Pull Request?
...