TheThingsNetwork / lorawan-stack-migrate

Migrate devices from other LoRaWAN Network Servers to The Things Stack
Apache License 2.0
8 stars 3 forks source link

CLI improvements proposal: positional argument #65

Closed happyRip closed 1 year ago

happyRip commented 1 year ago

Summary

Closes #56

Changes

Testing

local testing

Regressions

I do not expect any.

Notes for Reviewers

Checklist

adriansmares commented 1 year ago

Is this flag magic really necessary? Why don't we have commands per source with their own flag sets?

@happyRip I think this actually may be better than our current hack. We would need to generate dynamically an application / device sub command per source, but I think it would indeed work better here.

adriansmares commented 1 year ago

What is the status here - is this blocked on anything ? Does it need any technical decision ?

happyRip commented 1 year ago

Subcommands approach was merged, so this PR can be closed.