search

TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
932 stars 301 forks source link

Fix integrations field mask generation in JS SDK #2068

Open bafonins opened 4 years ago

bafonins commented 4 years ago

Summary

Current implementation of fieldMaskFromPatch can reset fields on the pubsub integration.

Steps to Reproduce

See https://github.com/TheThingsNetwork/lorawan-stack/pull/1991#issuecomment-587072856

What do you see now?

Fields being reset

What do you want to see instead?

Reset/update only provider fields from the patch

Environment

v3.6.0-rc1

Can you do this yourself and submit a Pull Request?

Yes

bafonins commented 3 years ago

Moving to Next up since this doesnt cause any problems with the current setup and there are issues with higher priority to work on.