TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
975 stars 306 forks source link

Unclear error message when configuring devices to GJS #2646

Closed laurensslats closed 4 years ago

laurensslats commented 4 years ago

Summary

Error is received when adding devices to the GJS.

Note: Not clear if this is a bug, or poor documentation.

...

Steps to Reproduce

  1. Set join-server-grpc-address to: 'tti.join.cloud.thethings.industries:8884'
  2. Create an application
  3. Register a device usine JoinEUI: 70B3D57ED0000000
  4. Add --net-id --supports-join --touch 5 receive error

P.S. I followed the docs: https://enterprise.thethingsstack.io/v3.8.1/getting-started/cloud-hosted/tti-join-server/

What do you see now?

$ ttn-lw-cli end-devices set tti-ch-test-app ttn-uno-gjs \
  --net-id 000013 \
  --supports-join \ 
  --touch
error:pkg/networkserver:field_mask (invalid field mask)
    correlation_id=cf75d9d63220447daf28bda2b4d72cb2
--- error:pkg/ttnpb:prohibited_field (field `supports_join` is prohibited)
    field=supports_join

...

What do you want to see instead?

{
  "ids": {
    "device_id": "ttn-uno-gjs",
    "application_ids": {
      "application_id": "tti-ch-test-app"
    },
    "dev_eui": "0004A30B001C6451",
    "join_eui": "70B3D57ED0000000"
  },
  "created_at": "2020-06-06T17:19:47.330Z",
  "updated_at": "2020-06-09T13:01:30.207753911Z",
  "network_server_address": "tti.eu1.cloud.thethings.industries",
  "join_server_address": "tti.join.cloud.thethings.industries",
  "lorawan_version": "1.0.2",
  "lorawan_phy_version": "1.0.2-b",
  "frequency_plan_id": "EU_863_870_TTN",
  "supports_join": true,
  "net_id": "000013"
}

...

Environment

v3.8.1 ...

How do you propose to implement this?

Validate the error message with Johan & Hylke ...

How do you propose to test this?

  1. Create a new app
  2. Add a new device to the GJS
  3. Test if it joins

...

Can you do this yourself and submit a Pull Request?

Need input from @johanstokking or @htdvisser ...

laurensslats commented 4 years ago

Found out it was a documentation issue