search

TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
980 stars 309 forks source link

Improve handling stack component addresses in the Console #2694

Closed bafonins closed 3 years ago

bafonins commented 4 years ago

Summary

Currently, the UI for setting stack component addresses can be ambiguous to novice users.

Why do we need this?

Hide specifics under default options such that new users do not have to deal with ttn stack specifics.

What is already there? What do you see now?

  1. Usage of {component} Server address
  2. Application link, device general settings, gateway creation, gateway general settings - requires the users to specify stack component addresses

What is missing? What do you want to see?

  1. Use {component} server host instead of {component} server address as we require the users to specify only host names and not full addresses.
  2. Hide input fields under a checkbox with title Use default {component} Server host which is initially checked. Reveal the input and allow the user to specify custom host only when the checkbox is unchecked.

Environment

v3.8.3

How do you propose to implement this?

Extend validation schema to process checkbox values. Conditionally render text inputs on checkbox value changes

How do you propose to test this?

Setup application link, create gateway, edit gateway, edit end device, create end device

Can you do this yourself and submit a Pull Request?

yes

bafonins commented 4 years ago

Blocked by https://github.com/TheThingsNetwork/lorawan-stack/pull/2644. Just to refactor all at once

bafonins commented 4 years ago

Blocked on https://github.com/TheThingsNetwork/lorawan-stack/issues/2813

kschiffer commented 3 years ago

3522 includes a fix for the end device registration process and the same behavior can be used for the general settings as well. The updated gateway registration will likely use the same mechanic, but this is still in planning.

I'll remove the blocked and needs/ux labels, since this is now actionable as part of #3522 at least for end devices.

johanstokking commented 3 years ago

@bafonins what is the status here?

bafonins commented 3 years ago

@johanstokking See my comment regarding JS address handling in DR form

kschiffer commented 3 years ago

See also #3947

bafonins commented 3 years ago

Blocked on https://github.com/TheThingsNetwork/lorawan-stack/issues/3947