search

TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
936 stars 302 forks source link

Fix field styling #3469

Closed bafonins closed 3 years ago

bafonins commented 3 years ago

Summary

After https://github.com/TheThingsNetwork/lorawan-stack/pull/3162 the login screen looks like this:

Screenshot 2020-11-12 at 13 26 43

Steps to Reproduce

  1. Go to the login screen on the main branch

What do you see now?

Broken field styling

What do you want to see instead?

Screenshot 2020-11-12 at 13 28 56

Environment

v3.10

Can you do this yourself and submit a Pull Request?

@kschiffer @benolayinka

bafonins commented 3 years ago

I also noticed that the glossary icon placement varies between desktop and mobile screens:

Screenshot 2020-11-12 at 13 57 07 Screenshot 2020-11-12 at 13 57 37
kschiffer commented 3 years ago

Appears like @benolayinka rebased, force-pushed and merged his outdated local branch instead of the updated one.

bafonins commented 3 years ago

Additionally, with https://github.com/TheThingsNetwork/lorawan-stack/pull/3162 we no longer can use cy.findByLabelText directly. For fields with the glossary icon we must must regex, e.g. instead of cy.findByLabelText('LoRaWAN Version'), cy.findByLabelText(/LoRaWAN Version/) must be used.

kschiffer commented 3 years ago

That can be fixed by adjusting the markup and styling a little so that the label content stays pure. However, I don't have time to work on that now.