TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
975 stars 306 forks source link

Harmonize testing of device registry RPCs #53

Closed johanstokking closed 5 years ago

johanstokking commented 5 years ago

Summary:

Harmonize testing of the RPC device registries.

Why do we need this?

For code quality of the open source project and a consistent way of testing.

What is already there? What do you see now?

  1. Join Server tests have been rewritten recently, has full test coverage, is readable and can be further extended
  2. Network Server tests have been rewritten recently in the style we want to follow.
  3. Application Server tests starts up the AS component and uses an RPC client

What is missing? What do you want to see?

  1. NS tests are okay. This one serves as a reference
  2. AS tests should be like NS.
  3. JS tests are okay, but ideally they should be more consistent with NS, if possible.

How do you propose to implement this?

Use the same mechanism. Note that there are minor differences;


Original issue: https://github.com/TheThingsIndustries/lorawan-stack/issues/1459 by @johanstokking

johanstokking commented 5 years ago

Closed by #177