nicholaspcr
commented
2 years ago While working on #5708 I encountered a panic on the network server when trying to import a CSV file.
The file used can be found in this issue.
The steps to reproduce the error are:
- Start TTS
- Create application
- Import CSV using the CLI (doc reference) or Console
- It will return an internal error.
The logs of the CLI - > cli.txt The logs of the Stack - > server.txt (The panic can be found on the line 117)
Summary
References https://sentry.io/organizations/the-things-industries/issues/3103305258 References https://sentry.io/organizations/the-things-industries/issues/3107052796
This issue tracks missing validation rules from the NS device registry
Setoperations.Why do we need this?
In order to avoid runtime errors caused by the fact that invalid end device settings were provided via
Set.What is already there? What do you see now?
The
Setvalidation mechanism.What is missing? What do you want to see?
The uplink channel generation needs to be validated when adding factory preset frequencies. What can happen is that a user in the
EU_863_870band provides 9 frequencies which are completely disjoint from the frequencies of the frequency plan. This results in 17 (desired) channels, which cannot be manipulated viaLinkADRReq(as the command is limited at 16 channels).Data rate offsets need to be validated based on the frequency plan ID / regional parameters version. This is currently not validated and causes errors during RX1 data rate selection
PHY and MAC version pairs should be validated and a warning should be generated if the pairing is suspicious (PHY 1.0.2b but MAC LoRaWAN 1.0.3)
Environment
v3.19How do you propose to implement this?
How do you propose to test this?
Manual testing.
Can you do this yourself and submit a Pull Request?
Yes