search

TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
975 stars 306 forks source link

Promote bunstore and remove gormstore #5643

Closed htdvisser closed 1 year ago

htdvisser commented 2 years ago

Summary

https://github.com/TheThingsNetwork/lorawan-stack/pull/5642 added a new implementation of the Identity Server storage layer (pkg/identityserver/bunstore) behind a feature flag (is.bunstore). Once we're satisfied with the new implementation, we should...

  1. Enable the feature flag by default, still allowing it to be disabled in case of unexpected behavior.
  2. Remove the feature flag and the old implementation (pkg/identityserver/gormstore).

This issue replaces https://github.com/TheThingsNetwork/lorawan-stack/issues/3250

Current Situation

Desired Situation

The old implementation should be gone once the new implementation is promoted to "stable".

Code of Conduct

nicholaspcr commented 2 years ago

Writing here that it was agreed on 13/09/22 meeting that on the v3.22.0, the bunstore should be set as the default store and there should be an option to enable the gormstore. Basically invert the current situation where bunstore is only used if explicitly set through the experimental flags.

After a certain amount of time drop the gormstore implementation. Using this issue

nicholaspcr commented 2 years ago

Keeping this updated for interested parties. This is being tested on TTN and making it the default store was postponed due to the following bugs: #5843, #5830.

nicholaspcr commented 1 year ago

Updating this issue.

The bunstore was set as the default implementation on #5897 but there is still the need to remove the gormstore implementation from the codebase.

nicholaspcr commented 1 year ago

Closing this since the gormstore was removed in https://github.com/TheThingsNetwork/lorawan-stack/pull/6009