TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
932 stars 301 forks source link

Add unique id to events #580

Closed bafonins closed 3 years ago

bafonins commented 5 years ago

Summary:

We need to uniquely identify events. References: https://github.com/TheThingsNetwork/lorawan-stack/pull/570

Why do we need this?

Currently a combination of time and name is used as the key, however this can cause overlaps.

What is already there? What do you see now?

  1. The Event proto, see https://github.com/TheThingsNetwork/lorawan-stack/blob/master/api/events.proto

What is missing? What do you want to see?

  1. The id entry that uniquely identifies the event

Environment:

stack

Can you do this yourself and submit a Pull Request?

I can do that with guidance from someone who is familiar with the way events work.

kschiffer commented 3 years ago

As far as I can see, events with the exact same timestamp should not happen, meaning that

cc @johanstokking

johanstokking commented 3 years ago

My proposal would be: