TheThingsNetwork / lorawan-stack

The Things Stack, an Open Source LoRaWAN Network Server
https://www.thethingsindustries.com/stack/
Apache License 2.0
961 stars 303 forks source link

Remove Join Server Application Activation Settings #6071

Open johanstokking opened 1 year ago

johanstokking commented 1 year ago

Summary

The Application Activation Settings in the Join Server are used as fallback for activation settings in the Join Server. These settings are only really relevant when working with external Join Servers. Since TTS Join Server is no longer intended to be used as a stand-alone Join Server (it's superseded by The Things Join Server in that role), these settings are no longer relevant.

References https://github.com/TheThingsNetwork/lorawan-stack/issues/3413

Current Situation

We currently have the AAS with rpcs to manage this: https://github.com/TheThingsNetwork/lorawan-stack/blob/v3.24/api/joinserver.proto#L328-L351 and below.

Why do we need this? Who uses it, and when?

We can remove this.

Proposed Implementation

Deprecate the API and remove it entirely. This is not used by the Console and there is no longer a CLI use case for this.

Contributing

Code of Conduct

adriansmares commented 1 year ago

Needs migration path for existing E2E encrypted AWS Integrations that still use the KEK.