This quickfix PR will fix an issue that can make the application stream stop after fetching the initial events.
Changes
Fix mutated state object in the GET_APP_EVENT_MESSAGE_SUCCESS reducer
Fix typo in store setup
Testing
Steps
Go to the device list view of an application
After around 15 seconds, go to the live data page
Observe that the live data has stopped working
Notes for Reviewers
The issue is related to the recent store updates in that the store is now stricter in preventing reducers that mutate the store object directly.
@PavelJankoski I will fix the storybook setup in a separate PR which targets the redesign branch.
Checklist
[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
[x] Documentation: Relevant documentation is added or updated.
[x] Testing: The steps/process to test this feature are clearly explained including testing for regressions.
[x] Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
[x] Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
[x] Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.
Summary
This quickfix PR will fix an issue that can make the application stream stop after fetching the initial events.
Changes
GET_APP_EVENT_MESSAGE_SUCCESSreducerTesting
Steps
Notes for Reviewers
The issue is related to the recent store updates in that the store is now stricter in preventing reducers that mutate the store object directly.
@PavelJankoski I will fix the storybook setup in a separate PR which targets the redesign branch.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.