Closed rvolosatovs closed 5 years ago
I think we can remove the discussion label here. This is clearly something we need to do.
This looks very promising but
a. It's still in the alpha
stage.
b. has the following issues with go
andgogoproto
.
https://github.com/lyft/protoc-gen-validate/issues?q=is%3Aopen+is%3Aissue+label%3AGo
@rvolosatovs looks like you did your contribution for this issue, are you still assigned?
Nope.
We're closing this. Refer to https://github.com/TheThingsIndustries/protoc-gen-fieldmask/issues/21
Summary:
Switch to https://github.com/lyft/protoc-gen-validate for validation instead of https://github.com/mwitkow/go-proto-validators
Why do we need this?
gogo
extensionsWhat is already there? What do you see now?
https://github.com/mwitkow/go-proto-validators
What is missing? What do you want to see?
https://github.com/lyft/protoc-gen-validate
How do you propose to implement this?
protoc
flags to call https://github.com/lyft/protoc-gen-validateWhat can you do yourself and what do you need help with?
~I'll take care of adding https://github.com/lyft/protoc-gen-validate to https://github.com/TheThingsIndustries/docker-protobuf. Possibly reuse https://github.com/znly/docker-protobuf/pull/54~ The protoc image contains the plugin since version
3.0.26