search

TheThingsProducts / gateway

The Things Kickstarter Gateway
https://www.thethingsindustries.com/docs/gateways/models/thethingskickstartergateway
55 stars 20 forks source link

Host header does not contain the port #60

Closed adriansmares closed 5 years ago

adriansmares commented 5 years ago

This is a bug report.

What do you want to do? What do you expect?

While requesting the gateway configuration from the Account Server, the gateway does not specify the port in the Host header, even though it is a non-standard HTTP port.

What steps did you take? (Give as many details as possible so that we can reproduce it)

Run an Account Server on port 1885.

What went wrong? What is missing?

The gateway did not specify the port in the Host header while requesting the gateway configuration.

What firmware is running on your gateway?

v1.0.5

What do the logs show?

Not applicable.

Any Screenshots or Photos?

Not applicable.

Do you think you can try to fix this yourself and submit a pull request?

Not really - I think the HTTP stack doesn't fill the port correctly.

johanstokking commented 5 years ago

Is this critical?

Can we work around this?

adriansmares commented 5 years ago

If the v3 IdentityServer exposes the API on port 80 or 443, this issue can be avoided. Otherwise, servers running on different ports will generate the wrong frequency plan URL, due to the lack of port.

htdvisser commented 5 years ago

Ref https://github.com/TheThingsNetwork/lorawan-stack/pull/436